connect darkMode slots only once#3145
Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom Sep 8, 2024
Merged
Conversation
| ) | ||
| QAPP.setProperty("darkMode", darkMode) | ||
| if not _pgAppInitialized: | ||
| _pgAppInitialized = True |
Check notice
Code scanning / CodeQL
Unused global variable
Member
|
Thanks for fixing this @pijyoi a global is the right solution here for sure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3143
In PySide6 > 6.7.2, it is no longer possible to use
UniqueConnectionwith free-standing functions. The end result of supplying that mode is that no connection will be made at all.This can be worked-around by manually keeping track of whether a connection has already been made.
In fact, the original code has a recursion issue. In the slot,
mkQApp()is called, which then attempts to connect the slot again, relying onUniqueConnectionto mask out this recursion.