Fix scaling with locked aspect#3100
Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom Oct 13, 2024
a17sol:locked-aspect-fix
Merged
Fix scaling with locked aspect#3100j9ac9k merged 1 commit intopyqtgraph:masterfrom a17sol:locked-aspect-fix
j9ac9k merged 1 commit intopyqtgraph:masterfrom
a17sol:locked-aspect-fix
Conversation
Contributor
Author
|
Bump @j9ac9k |
Member
|
Thanks for your patience @a17sol the PR LGTM. ViewBox.py is a real fragile file to touch, and would likely benefit substantially from more tests so we can be more confident about making optimizations/refactors. Merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an undocumented (?) issue with scaling ViewBoxes with locked aspect ratio when the mouse is over the axes.
How to reproduce the issue
Bugs Found And Changes Made
Fixed by removing unnecessary if-condition.
1.1 The function argument 'force' has become useless, so it has been removed from the signature and from calls using it.
A check has been added to determine which axis is the primary axis, and the secondary axis is scaled accordingly.
Results
When trying to reproduce the issue, there are no zoom jumps and mouse wheel works as expected.