bugfix: PlotCurveItem OpenGL didn't invalidate render_cache on cleanup#3089
Merged
j9ac9k merged 2 commits intopyqtgraph:masterfrom Jul 7, 2024
Merged
bugfix: PlotCurveItem OpenGL didn't invalidate render_cache on cleanup#3089j9ac9k merged 2 commits intopyqtgraph:masterfrom
j9ac9k merged 2 commits intopyqtgraph:masterfrom
Conversation
Member
|
Nice catch, thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cleanup()is intended to be called for the following reasons:For both cases, OpenGL objects are destroyed.
For case (2), the state of the class is expected to be restored to a freshly initialized state, in preparation for a re-initialization.
The bug here is that
render_cachewas not invalidated even though the VBO that it was relying on had just been nuked.Included is a change to
MouseSelection.pyto trigger this bug.