RawImageGLWidget: update uploaded state on cleanup#3043
Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom Jun 4, 2024
Merged
RawImageGLWidget: update uploaded state on cleanup#3043j9ac9k merged 1 commit intopyqtgraph:masterfrom
j9ac9k merged 1 commit intopyqtgraph:masterfrom
Conversation
cleanup (followed by initializeGL) will be called if QOpenGLWidget gets reparented (and not just during application shutdown) in such a case, state variables need to be maintained.
Member
|
Just ran this on macOS, confirmed it's working. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cleanup (followed by initializeGL) will be called if QOpenGLWidget gets reparented (and not just during application shutdown)
in such a case, state variables need to be maintained.
A script that demonstrates the scenario:
RawImageGLWidgetis first created parent-less andshow()n.RawImageGLWidgetto be a top-level window and triggers creation of an OpenGL contextQMainWindow.RawImageGLWidgetto no longer be a top-level window and triggers the creation of a new OpenGL contextWithout this PR, a black window will be displayed.