Overhaul PlotDataItem documentation#3039
Merged
j9ac9k merged 7 commits intopyqtgraph:masterfrom Jun 6, 2024
Merged
Conversation
62d5fa4 to
aad937f
Compare
aad937f to
052b28d
Compare
| sat: int | ||
| alpha: int | ||
|
|
||
| color_like: TypeAlias = ( |
Check notice
Code scanning / CodeQL
Unused global variable
fcf430b to
43e756b
Compare
38c35bb to
24e3856
Compare
In addition, add some type annotations, fix typos, greatly expand on the existing documentation, fix a variety of minor linter issues.
Since Qt signals can connect to other signals directly, we utilize that mechanism instead of being dependent on the intermediate slots, whose sole purpose is to emit another signal.
24e3856 to
2c553e8
Compare
2c553e8 to
1ed0f1a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately
PlotDataItemis very dependent on*argsand**kwargs, which makes doing the documentation and having it be verified rather difficult.