test_PolyLineROI now passes on non-AMD64 platforms#2999
Merged
j9ac9k merged 3 commits intopyqtgraph:masterfrom Apr 27, 2024
Merged
test_PolyLineROI now passes on non-AMD64 platforms#2999j9ac9k merged 3 commits intopyqtgraph:masterfrom
j9ac9k merged 3 commits intopyqtgraph:masterfrom
Conversation
Member
Author
pxCount=0 if platform.machine() == "AMD64" else 36😬 |
e40ae64 to
84199f7
Compare
4ca2ba6 to
16683b0
Compare
f20937e to
6ffb771
Compare
6ffb771 to
26aa153
Compare
21ba75e to
66bac6f
Compare
77bf5a7 to
18610b1
Compare
18610b1 to
a08b009
Compare
f31e916 to
1b07da9
Compare
0ba13e8 to
83d8707
Compare
The major source of the discrepancy of the images came from AntiAliasing This commit adds an attribute to ROIs and Handles, ._antialias, which is True by default, but anti-aliasing will be disabled when that attribute is set to False. The ROIs and Handles used in the test suite are set to have this attribute set to False, thus disabling the use of anti-aliasing. This change also required that I generate new baseline test images, which are included in the commit. Because of disabling anti-aliasing, the pxCount value for image comparison checker are substantially lower.
9e9b219 to
201f92e
Compare
Member
Author
|
ok, done tinkering, I think this PR is ready. I wish I had a better idea why the segfault in make_ARGB, but setting the |
0869271 to
e3549c6
Compare
Instead of having loops inside tests, use the pytest.mark.parametrize feature of pytest. This allows for far better readability of test failures, and a lot of duplicated code is removed.
e3549c6 to
955a8fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test suite now passes due to using a forgiving pxCount values when the test suite is running on not on
platform.machine() == 'AMD64'.Did formatting changes to
test_PolyLineROIand migrated the for loop to instead usepytest.mark.parametrizeQuestion now is, is this the "fix" we want to have?
An alternative would be to add new images for arm based platforms to test against.
Fixes #2998