Set Application Icon on windows#2992
Merged
j9ac9k merged 5 commits intopyqtgraph:masterfrom Apr 20, 2024
Merged
Conversation
If using pg.mkQApp(), the theme is now set to 'fusion', and some better handling of light and dark mode is set. Some instances of QApplication.paletteChanged removed now that its deprecated.
a4cde0d to
fe29e2e
Compare
pijyoi
reviewed
Apr 20, 2024
fe29e2e to
fa95d6d
Compare
Member
Author
|
actually while this looked good on Windows, just loaded up macOS with pyqt 5.15, and the example app looks like rubbish there, ...needs more investigation before merging. |
fa95d6d to
50f03dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes it so the peegee icon is visible on the taskbar on Windows. Furthermore, we set the
fusiontheme to applications created usingmkQApp(), which handled dark mode detection on windows with Qt 6.5+.What still isn't working is the peegee icon not showing up on gnome/kde desktops.