numpy 2.0: workaround regression in rescaleData#2974
Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom Apr 17, 2024
Merged
Conversation
b466c70 to
e74f521
Compare
Member
|
Thanks for keeping the library up to date w/ issues with upcoming releases of our dependencies! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing against NumPy 2.0rc1, a performance regression was noticed in
functions.rescaleData.The cause was traced to:
https://numpy.org/devdocs/numpy_2_0_migration_guide.html#changes-to-numpy-data-type-promotion
It does seem rather counter-intuitive that the new behavior should affect in-place operations:
e.g.
i.e. the resultant
dtypecan't change, so the performance regression might imply that a temporary higher precision ndarray was created? This would defeat the purpose of doing in-place operations.The fix in this PR is only applied to thenumpycodepath, and not to thecupyandnumbacodepaths.The
numbacodepath (functions_numba.rescaleData) already marks theoffsetandscalearguments as typef8.