set SymbolAtlas dpr to primary screen's dpr#2965
Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom Mar 16, 2024
Merged
Conversation
Member
|
walrus operator strikes again! Thanks for the PR @pijyoi LGTM 👍🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set the startup DPR of
ScatterPlotItem'sSymbolAtlasto the primary screen's DPR, so that users with hidpi screens are not penalized by a guaranteedSymbolAtlasrebuild.https://doc.qt.io/qt-6/qguiapplication.html#primaryScreen-prop says that:
This will be the screen where QWindows are initially shown, unless otherwise specified.Fixes #2960
Test script can be found in the comments of the linked issue.
Remarks:
ScatterPlotItemcan (surprisingly) be instantiated without aQGuiApplication, in which case there will be no primary screen.