Aaryamantriescode SyntaxWarnings #2962#2964
Merged
j9ac9k merged 5 commits intopyqtgraph:masterfrom Mar 16, 2024
Merged
Conversation
Member
|
Slight preference for a raw string ( |
Contributor
Author
|
Ok ill change that |
Member
|
Hi @aaryamantriescode Thanks for the PR, when using raw strings ( |
Contributor
Author
|
Is this fine now? |
Member
Need to remove the first (or second) slash here in the screen shot. |
Contributor
Author
|
😅got it |
Member
|
Thanks for the PR @aaryamantriescode ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2962
This was the issue [The $ should be written \$ or r'$' since a few Python releases (same for all backslash escape that have no meanings). I don't have the time to search for other occurrences of this fact, but running the tests with PYTHONDEVMODE=1 should help spotting them :)]
I think I found the issue and made changes