Do not move PlotCurveItem to origin#2950
Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom Mar 7, 2024
Merged
Conversation
The way I previously decided to fix pyqtgraph#2661 was to shift PlotCurveItems to be between (-1, 1). There are other complications with shifting the curve about the origin using PlotCurveItem.setData(). Furthermore, that fix only addressed the case of PlotCurveItem, and not other GraphicsItems. An issue did come up with after doing an SVG export, where the PlotCurveItem was moved out of the view with log-mode was enabled. The correct fix is likely to apply a transform to the GraphicsItems so they are positioned about the origin, and then have the QPainter instance look there, instead of where the view is. More experimentation would be needed to make that work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2941
Un-fixes #2661
The way I previously decided to fix #2661 was to shift PlotCurveItems to be between (-1, 1). There are other complications with shifting the curve about the origin using PlotCurveItem.setData(). Furthermore, that fix only addressed the case of PlotCurveItem, and not other GraphicsItems.
An issue did come up with after doing an SVG export, where the PlotCurveItem was moved out of the view with log-mode was enabled.
The correct fix is likely to apply a transform to the GraphicsItems so they are positioned about the origin, and then have the QPainter instance look there, instead of where the view is. More experimentation would be needed to make that work.