Merged
Conversation
this ensures that the path is a closed polygon. this matters for PenCap and PenJoin purposes.
Member
|
Thanks for the investigation @pijyoi and the partial improvement! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this ensures that the path is a closed polygon.
this matters for PenCap and PenJoin purposes.
test_PolylineROIhas the following series of test images:Prior to this PR, aarch64 (and ppc64le) platforms fail at
init. (See #2110)With this PR, the failure occurs later at
click_segment(anddrag_new_handle)When the path is not closed, we end up with a polyline with its ends rendered with
SquareCap, which according to Qt docs: "a square line end that covers the end point and extends beyond it by half the line width."It does so happen that the failing pixels in
initcorrespond to the closing point of the ROI handle.Failure screenshot for

click_segment. For this case, a lot more pixels are involved.