Refactor ImageItem QImage creation routines#2944
Merged
j9ac9k merged 2 commits intopyqtgraph:masterfrom Mar 7, 2024
Merged
Conversation
5e19269 to
bf8964c
Compare
67b9690 to
608822a
Compare
608822a to
ad7b4e6
Compare
Member
|
Thanks @pijyoi for this PR. ImageItem was getting complicated and there was some good stuff there so I'm a very big 👍🏻 for moving that functionality into free-standing functions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fast-path
QImagecreation methods residing withinImageItemcan be factored out to be free-standing functions.This has the following benefits:
ImageItemSome behavior changes:
nextafterwith the snippet in Fix UnderflowError in _try_rescale_float when maxVal == 0. #2881 (comment)ImageItemobject for each test. This could be problematic if the CI was flakey to begin with.