Prevent containerChanged from collapsing an entire container tree#2888
Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom Feb 14, 2024
Merged
Prevent containerChanged from collapsing an entire container tree#2888j9ac9k merged 1 commit intopyqtgraph:masterfrom
j9ac9k merged 1 commit intopyqtgraph:masterfrom
Conversation
In pyqtgraph#2887 it was observed that this line removes the container tree mid-construction if there is only one dock in a container. Preventing propagation here Fixes pyqtgraph#2887
Member
|
Thanks for the PR @UsYer Sorry it took me so long to get to this. Diff LGTM, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #2887 it was observed that this line removes the container tree mid-construction if there is only one dock in a container. Preventing propagation here fixes that problem.
I'm not sure if this causes other issues that I can't see from my limited knowledge of the code base.
Maybe someone knows more and can judge if this change is safe.
Fixes #2887