make ColorBarItem agnostic of the image kind#2879
Merged
j9ac9k merged 6 commits intopyqtgraph:masterfrom Nov 12, 2023
Merged
Conversation
lut no longer has precedence over cmap. whichever got set last wins.
cmap as an argument was previously deprecated. after the deprecation cycle had expired, the deprecation warning was removed but not the argument itself.
don't use the deprecated code path
Member
|
Love this diff @pijyoi thanks for the PR |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR seeks to make the support of
ColorBarItemfor the various image-likeGraphicsItemsmore consistent.It changes
ColorBarItemto update the image-like items under its control usingsetColorMapinstead ofsetLookupTable.It also tries to make
NonUniformImageand 'PColorMeshIteminternally more consistent when bothsetColorMapandsetLookupTable` have been used.Script to test that setting colormap from
ColorBarItempropagates to the various image-like items.