ButtonItem: draw pixmap to logical size#2873
Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom Nov 3, 2023
Merged
Conversation
Member
|
Thanks @pijyoi This is one of those issues in hindsight makes me think "oh yeah, that button is smaller on my laptop vs. my desktop", but never really realized it even as I was switching between displays. diff LGTM, merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On hidpi displays,
PlotItem's "auto" icon is rendered smaller, making it harder to click.This is due to
ButtonItemdrawing the pixmap in device pixels.This PR changes the drawing to use logical sizes so that the icon is the same size across different DPI displays.
Remarks:
The "auto" graphic is actually 32x32 while the logical size used is 14, which means that even on a DPI 2.0 display, we will have a nice non-blurry rendering.