Fix Python 3.12 DeprecationWarning: datetime.datetime.utcfromtimestamp()#2848
Merged
j9ac9k merged 3 commits intopyqtgraph:masterfrom Oct 30, 2023
bersbersbers:fix-#2847
Merged
Fix Python 3.12 DeprecationWarning: datetime.datetime.utcfromtimestamp()#2848j9ac9k merged 3 commits intopyqtgraph:masterfrom bersbersbers:fix-#2847
DeprecationWarning: datetime.datetime.utcfromtimestamp()#2848j9ac9k merged 3 commits intopyqtgraph:masterfrom
bersbersbers:fix-#2847
Conversation
DeprecationWarning: datetime.datetime.utcfromtimestamp()
Member
|
Thanks for the PR @bersbersbers ! Is there a reason we can't remove the platform specific if-statement and just use |
Contributor
Author
I haven't tried, to be honest. The platform-specific code was there before, and in an effort to affect as little code as possible while on my phone, I did not touch that part. |
Contributor
Author
|
(But feel free to edit/take over this PR.) |
Member
|
Taking a closer look, there could definitely be some room for cleanup; but that would involve a change that's far outside the scope of removing a deprecated method such as this PR aims to do. This LGTM, thanks for the PR @bersbersbers ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
utcfromtimestamp()is deprecated in Python 3.12. Fixes #2847.