fix: wrong key set to _pixelVectorCache#2795
Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom Aug 12, 2023
Merged
Conversation
Member
|
Ha, a bug that got merged not by me 🎊 Thanks for the PR @pijyoi nice find! At one point, I was debugging something related and was suspicious of bogus caching... and noticed one of those caches seemed to never hit; but as that wasn't what I was debugging, I moved on... |
Member
|
I can't speak to if the intended behavior is to return a copy of the point or not tho... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1212 changed the lookup key used for the local cache from
dtto a commonkeyused also by the global cache.The local cache update at the end of the function was not similarly modified to use
key.At worst, this causes the very first local cache lookup after a computation to always be a miss.
There appears to be another inconsistency present nearby. Elsewhere in the function (2 places), a copy of
pvis returned. This copying is not done for the return at the end of the function. This was already the behavior prior to #1212.