Merged
Conversation
Member
|
Thanks for the PR @pijyoi While there is a common case of no NaNs, NaNs have slipped into this library in a number of places I would not expect, the library should be able to behave in a predictable fashion if that's happening. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While adjusting an
ImageItem's levels interactively withHistogramLUTItemorColorBarItem, it is a waste to check for nans each time the same image data gets re-rendered.(Arguably, checking it even once is a waste, since the common case is that there are no nans.)
The example in #2779 (comment) can be used to show that this PR gives a good speedup.