Add turbo colormap to local ColorMaps and GradientEditorItem#2778
Merged
j9ac9k merged 2 commits intopyqtgraph:masterfrom Aug 24, 2023
Merged
Add turbo colormap to local ColorMaps and GradientEditorItem#2778j9ac9k merged 2 commits intopyqtgraph:masterfrom
j9ac9k merged 2 commits intopyqtgraph:masterfrom
Conversation
…nbow-colormap-for.html to default Gradients dict for GradientEditorItem.
Member
|
Would you consider adding the colormap in GradientEditorItem doesn't get as much usage as our ColorMap functionality. |
Contributor
Author
|
Sure thing! |
Member
|
@ptuemmler My apologies for taking so long to merge, I normally try and wrap things up far quicker than I have now. I've tested this works as intended, LGTM, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added turbo from https://ai.googleblog.com/2019/08/turbo-improved-rainbow-colormap-for.html to default Gradients dict in GradientEditorItem.py such that it can be used directly in ImageViews and their HistogramLUTItems.
Rainbow colormaps yield far greater contrast and depth differentiation than colormaps such as magma or viridis. Turbo is far more pleasant than the already available spectrum map and does not have the same banding issues as jet.