Skip to content

Update TextItem.py#2761

Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom
dingo9:patch-1
Jun 29, 2023
Merged

Update TextItem.py#2761
j9ac9k merged 1 commit intopyqtgraph:masterfrom
dingo9:patch-1

Conversation

@dingo9
Copy link
Copy Markdown
Contributor

@dingo9 dingo9 commented Jun 29, 2023

fix floating-point precision issues with QTransform.inverted()

Detail the reasoning behind the code change. If there is an associated issue that this PR will resolve add

Fixes #

Other Tasks

Bump Dependency Versions

Files that need updates

Confirm the following files have been either updated or there has been a determination that no update is needed.

  • README.md
  • setup.py
  • tox.ini
  • .github/workflows/main.yml and associated requirements.txt and conda environemt.yml files
  • pyproject.toml
  • binder/requirements.txt
Pre-Release Checklist

Pre Release Checklist

  • Update version info in __init__.py
  • Update CHANGELOG primarily using contents from automated changelog generation in GitHub release page
  • Have git tag in the format of pyqtgraph-
Post-Release Checklist

Steps To Complete

  • Append .dev0 to __version__ in __init__.py
  • Announce on mail list
  • Announce on Twitter

fix floating-point precision issues with QTransform.inverted()
@j9ac9k
Copy link
Copy Markdown
Member

j9ac9k commented Jun 29, 2023

nice find @dingo9, thanks for the PR!

I'm curious how you came stumbled across this, and if in your use-case this actually fixes an issue you're having.

Diff LGTM, merging

@j9ac9k j9ac9k merged commit d13dbea into pyqtgraph:master Jun 29, 2023
@dingo9
Copy link
Copy Markdown
Contributor Author

dingo9 commented Jul 6, 2023

nice find @dingo9, thanks for the PR!

I'm curious how you came stumbled across this, and if in your use-case this actually fixes an issue you're having.

Diff LGTM, merging

When I try to use np.datetimt64[ns] (view as np.int64 ) as the x values, TextItem disappeared sometimes, so I try to find why and fix this issue....

@dingo9 dingo9 deleted the patch-1 branch July 6, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants