Conversation
|
Whoops, nice catch on the use of the deprecated API. We should add a test to cover that codepath, but that's outside the scope of this PR. Why is the test being removed? Also, nice library, thanks for adding to the README! |
Ah I just removed a test which I had added in the previous commit, but which did not turn out to really test the issue I thought (wanted to test colorDistance by creating a colormap with linearize=True, but wasn't able to get to the colorDistance function this way). So in the end, I simply added a "stupid" test, that just checks whether colorDistance returns without raising am error If number of colors is 0 and 2. |
|
Whops, should have noticed that :D Thanks for the PR! |
Calling
pg.functions.colorDistance([])raises an error when using numpy >= 1.20, becausenp.floatis deprecated, see https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations.np.floatresults in crash when callingpg.functions.colorDistance([])#2738Other Tasks
Bump Dependency Versions
Files that need updates
Confirm the following files have been either updated or there has been a determination that no update is needed.
README.mdsetup.pytox.ini.github/workflows/main.ymland associatedrequirements.txtand condaenvironemt.ymlfilespyproject.tomlbinder/requirements.txtPre-Release Checklist
Pre Release Checklist
__init__.pyCHANGELOGprimarily using contents from automated changelog generation in GitHub release pagePost-Release Checklist
Steps To Complete
.dev0to__version__in__init__.py