PySide6 6.5.1 compatibility updates#2734
Merged
ntjess merged 2 commits intopyqtgraph:masterfrom May 28, 2023
Merged
Conversation
Member
|
Oh, never noticed the connection to the |
ntjess
reviewed
May 28, 2023
the inner function actually captures both "self" and "self.pen"
Contributor
Author
|
On further reflection, there is a behavior change made by this PR. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies code patterns in pyqtgraph that are triggering failures on the CI with PySide6 6.5.1
Signal.emitinstead of directly to the signalTo be clear, this PR only makes the CI pass.
Whether more functionality has been broken (but not captured by the CI) is unknown.