Adapt hide icon (invisible eye) to style of other icons#2731
Adapt hide icon (invisible eye) to style of other icons#2731j9ac9k merged 1 commit intopyqtgraph:masterfrom
Conversation
|
As this is a bit different scope compared to the other pyqtgraph icons, I am not sure. Yes, I agree the changed style is similar to other already built-in buttons, but should it be like that? Is it supposed to resemble button? other icons clearly are to be seen as button, but this - is it or should it be? For me it looks that it is only to hint the visibility state of QtGraphicsItem, or of the curve or pyqtgraph "DatasetItem" |
|
@stephan-senkbeil Thanks for the PR, sorry it took so long for a maintainer to respond While I'm not completely sold on this icon being right, we don't have a particularly consistent style here; and this PR is certainly an improvement, so I'm going to merge. That said, if someone has experience in this area, and wants to contribute a set of icons that are easily accessible in pyqtgraph, please reach out; either by creating an issue or contacting me via one of the methods in my github user profile. |
The icon that is displayed when hiding a curve by clicking on the corresponding legend entry is out of style compared to all other icons used.
This PR updates this icon to reflect the style of the other icons in
icons.svg.I used the eye of the old icon and the background of one of the icons from
icons.svgto create the new icon.Before:
After:
