guard against auto-downsample oscillation#2726
Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom Jun 3, 2023
Merged
Conversation
9ffc119 to
9a978fc
Compare
Member
|
I'm going to go ahead and merge this despite not hearing from the author of the issue. The diff LGTM. Thanks @pijyoi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix #2713 where for particularly large data sets, the auto-downsampled value never stabilizes and instead oscillates between two values.
If a newly computed auto-downsample value differs very little from the previous calculated value, then the previous value is used instead.