Don't draw InfiniteLine anti-aliased if vertical or horizontal#2709
Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom May 3, 2023
Merged
Don't draw InfiniteLine anti-aliased if vertical or horizontal#2709j9ac9k merged 1 commit intopyqtgraph:masterfrom
j9ac9k merged 1 commit intopyqtgraph:masterfrom
Conversation
Member
|
Thanks @bbc131 I agree with this change. Thanks for the detailed PR and code to replicate the issue 👍🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The InfiniteLine is always drawn with anti-aliasing. This leads to the effect, that a even if the line is oriented vertically or horizontally, it might appear blurry and a bit darker if its position lies actually "between" two pixels.
This effect is even more problematic, if one has multiple lines next to each other and some of them are bright and clear and some are blurry.
See the following screenshots, which are produced with the code at the end of this post.
The first screenshot shows the current state with anti-aliasing in all cases. The left vertical line ('vertical (line_2)') appears darker than the right one ('vertical').
The second screenshot is produced with the same example code below, but with the present PR applied. There, InfiniteLine is drawn with anti-aliasing only if the line is not horizontally and not vertically oriented.
Therefore, both vertical lines appear identically.
(I show the effect only for vertical lines, but the same applies to horizontal lines.)
Before

After
