GLViewWidget: fix mouse pos jumps when mouse tracking is off#2698
Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom Apr 19, 2023
Merged
GLViewWidget: fix mouse pos jumps when mouse tracking is off#2698j9ac9k merged 1 commit intopyqtgraph:masterfrom
j9ac9k merged 1 commit intopyqtgraph:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug caused by #2653 and reported in #2653 (comment)
When mouse tracking is off, mouse move events are only delivered when the mouse button is pressed down.
Thus when the user releases the mouse button at position "A" and subsequently presses the mouse button at position "B", this results in the code seeing the mouse jump from "A" to "B".
If "A" and "B" are far apart, this results in a large panning or orbiting operation.