Skip to content

Allow macOS to have fudge factor in test_polyROI#2687

Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom
j9ac9k:fudge_for_new_macos
Apr 13, 2023
Merged

Allow macOS to have fudge factor in test_polyROI#2687
j9ac9k merged 1 commit intopyqtgraph:masterfrom
j9ac9k:fudge_for_new_macos

Conversation

@j9ac9k
Copy link
Copy Markdown
Member

@j9ac9k j9ac9k commented Apr 13, 2023

I noticed a test failure locally when I tested after PyQt6 6.5 was released, it turned out to be a macOS issue, not a Qt version issue. Not sure when this test started failing, but the current macOS CI runs on macOS 12, whereas I have macOS 13.3.1 on my machine right now.

@j9ac9k
Copy link
Copy Markdown
Member Author

j9ac9k commented Apr 13, 2023

It should be noted that the packaging library comes with pytest, so we have access to it (I'm not introducing an extra dependency I promise :) )

@j9ac9k j9ac9k merged commit e98dbaa into pyqtgraph:master Apr 13, 2023
@j9ac9k j9ac9k deleted the fudge_for_new_macos branch April 13, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant