Avoid changing background colors of text and rows for group parameter…#2683
Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom Apr 14, 2023
Merged
Avoid changing background colors of text and rows for group parameter…#2683j9ac9k merged 1 commit intopyqtgraph:masterfrom
j9ac9k merged 1 commit intopyqtgraph:masterfrom
Conversation
Member
|
This is what things look like on macOS with dark mode. Still getting the overlapping text but that's been an issue for ages. Otherwise it looks good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most themes (including defaults on windows and gnome) use alternating colors for each table row. Current styling doesn't play nice with this assumption
This PR simply removes row and font coloring to avoid those difficulties:
Note that in the "before" samples (before this PR), the colors don't match on alternate rows, styling doesn't stand out very well, and (importantly) on some popular styling choices (there are more on GH), the text isn't properly changed and appears as very low contrast against the background.
I feel this is sufficient reason to restrain from changing background colors. I tested on a few more themes without screenshots, but I don't think there are any cases where the PR causes a worse appearance. Notably,
qt-materialisn't happy either way, but the problem doesn't get exacerbated with these changes.