Return float values from QColor in getByIndex#2648
Merged
j9ac9k merged 2 commits intopyqtgraph:masterfrom Mar 13, 2023
Merged
Conversation
j9ac9k
reviewed
Mar 12, 2023
Member
|
Thanks for the PR! I added one comment regarding the imports in the test code. Once you make that change, I'll approve and run on the CI system 👍🏻 |
Member
|
Thanks @nickdimitroff this LGTM! Merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
ColorMap_getByIndexreturn floats for RGB values to fit expectations.Fixes #2627