PColorMeshItem: implement dataBounds and pixelPadding#2586
PColorMeshItem: implement dataBounds and pixelPadding#2586j9ac9k merged 3 commits intopyqtgraph:masterfrom
Conversation
fc3575e to
58c5e19
Compare
|
Looking at the very first commit of the PR #1273 for As
def width(self):
if self.x is None:
return None
return len(self.x)
def height(self):
if self.y is None:
return None
return len(self.y)
def boundingRect(self):
if self.z is None:
return QtCore.QRectF(0., 0., 0., 0.)
return QtCore.QRectF(0., 0., float(self.width()), float(self.height())) |
8b4e9e4 to
091b39f
Compare
|
Would it make sense to force/require the edgecolor pen to be cosmetic? It would simplify the |
|
Hi @pijyoi sorry for the late response. I don't think the |
It's okay to support thick cosmetic pens. That code is within The code that supports non-cosmetic pens is within |
I'm good with that. |
091b39f to
282f9f9
Compare
|
Thanks @pijyoi for patching up PColorMeshItem! Changes LGTM, merging! |
using
QPicture.boundingRect()to computeboundingRect()has issues, which includes rounding the values to the next integral value.Other issue fixed:
width()andheight()methods assume that the minimum coord is 0Script that demonstrates the issues fixed by this PR.
master.master.