Remove antiquated Qt crash prevention#2573
Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom Jan 7, 2023
NeilGirdhar:master
Merged
Remove antiquated Qt crash prevention#2573j9ac9k merged 1 commit intopyqtgraph:masterfrom NeilGirdhar:master
j9ac9k merged 1 commit intopyqtgraph:masterfrom
NeilGirdhar:master
Conversation
Member
|
Hi @NeilGirdhar Thanks for the PR, I always love to clean up older, likely unused code. Looking through git blame I came across this commit which is also related to TensorFlow compatibility b9c7e37 I'm good with killing off this code section... I always hated messing with garbage collection, I'll leave this PR up for a day or so to see if any other maintainer has an issue with it; if not, I'll merge. |
Member
|
Merging, thanks for debugging this @NeilGirdhar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2572
Other Tasks
Bump Dependency Versions
Files that need updates
Confirm the following files have been either updated or there has been a determination that no update is needed.
README.mdsetup.pytox.ini.github/workflows/main.ymland associatedrequirements.txtand condaenvironemt.ymlfilespyproject.tomlbinder/requirements.txtPre-Release Checklist
Pre Release Checklist
__init__.pyCHANGELOGprimarily using contents from automated changelog generation in GitHub release pagePost-Release Checklist
Steps To Complete
.dev0to__version__in__init__.py