Improve ChecklistParameter.setValue logic.#2544
Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom Dec 4, 2022
Merged
Conversation
Previously, calling `setValue` would properly fill in child checklist widgets, but wouldn't populate `self.opts["value"]` with the correct option. This was because setting `blockSigal=self._onChildChanging` meant `childrenValues()` wasn't notified that child values were updated. Simply creating and passing a `valueToSet` object prevents these issues.
Member
|
Thanks for the PR @ntjess this LGTM, merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, calling
setValuewould properly fill in child checklist widgets, but wouldn't populateself.opts["value"]with the correct option. This was because settingblockSigal=self._onChildChangingmeantchildrenValues()wasn't notified that child values were updated. Simply creating and passing avalueToSetobject prevents these issues.I found this bug by calling
restoreState, which updates a checklist's value without bubbling up from its widget children.As a bonus, I (at least tried to) improve the readability of
setValuelogic.