Minor improvements to InteractiveFunction ecosystem#2521
Merged
ntjess merged 6 commits intopyqtgraph:masterfrom Nov 10, 2022
Merged
Minor improvements to InteractiveFunction ecosystem#2521ntjess merged 6 commits intopyqtgraph:masterfrom
InteractiveFunction ecosystem#2521ntjess merged 6 commits intopyqtgraph:masterfrom
Conversation
…ons. This is a hold-over from when a button was either added or removed from a tree depending on button options. Now, the button is always present and simply hidden/not hidden based on button options. Thus, the tree widget will never change as a result of button opts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InteractiveFunctionwould still declare themselves to beInteractiveFuntionobjects whenstr()was called. This no longer happensparam->parameters)resolveAndHookupParameterChild. It may be desirable to subclassInteractorand optionally ignore some children depending on a criteria (i.e., not a valid parameter type). In these cases, a simple change of allowing aNonereturn value accommodates this. See the additional test case for an example. I considered making this default behavior forInteractor, but I wasn't sure if it was more sensible to fail (the current behavior), add toextra, or ignore. It is easy enough for users to customize for their needed behavior through a subclass, so I left the normalinteractAndHookupParameterChildbehavior for now.addChild, which preserves old behavior and works in the new test case.