fix setMaximumHeight(1e6) in SpinBox.py#2519
Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom Nov 4, 2022
Merged
Conversation
in method of Qt 5.15.6 SpinBox setMaximumHeight does not accept float. changing 1e6 (which produces 1million in float) to integer 1000000
Member
|
Thanks for this fix; Python 3.10 removed a compatibility layer that I believe under the hood did a lot of the float-to-int conversions for us within the bindings. When Python 3.10 was coming out, we patched up a bunch of these, but clearly, a few instances slipped through the cracks. It looks like we have a similar issue with AxisItem.py, although I haven't seen any issue like it. Thanks for the PR @sem-geologist merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After upgrading my KDE Neon and thus Qt to 5.15.6 I had found out that my software hiccups at pytqgraph SpinBox. I had tracked down problem to SpinBox.py, where method
setMaximumHeightis fed with1e6which is float, and these are pixels (logically it should be integer numbers). Interestingly older Qt versions had not complained before and was consuming float without any complaining. Simple fix is to change this1e6to1000000.This fix is simple and straightforward.