Make ActionGroup compatible with existing Parameter conventions#2505
Merged
j9ac9k merged 2 commits intopyqtgraph:masterfrom Nov 1, 2022
Merged
Make ActionGroup compatible with existing Parameter conventions#2505j9ac9k merged 2 commits intopyqtgraph:masterfrom
ActionGroup compatible with existing Parameter conventions#2505j9ac9k merged 2 commits intopyqtgraph:masterfrom
Conversation
- The name didn't end with `Parameter` which is unlike every other class - `sigActivated` should emit `self` instead of nothing - `emitStateChanged` should be fired during `activate`
Contributor
|
Any public API concerns from the name change? |
Contributor
Author
|
@ksunden This class was introduced in 0.13, so thankfully the API issue isn't binding at this point. Also, the parameter type is considered "private" (leading underscore), so even since the 0.13 release I don't think it would be widely |
Member
|
I think we should probably leave the old class with a deprecation warning, saying it will be removed in the first pyqtgraph release after January, 2023. The old class, calling the "correct" named class. If it wasn't already in a release I would say we can just rename it, but it's been like this for long enough it might impact someone. |
Contributor
Author
|
Very understandable. Will do |
j9ac9k
reviewed
Oct 30, 2022
5923d8c to
830b71f
Compare
Contributor
Author
|
Good catch! |
Contributor
Author
|
@j9ac9k Ok to merge? |
Member
|
whops, yes! Sorry! I'll press the buttan! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parameterwhich is unlike every other classsigActivatedshould emitselfinstead of nothingemitStateChangedshould be fired duringactivate