Remove old unused mains#2490
Merged
j9ac9k merged 2 commits intopyqtgraph:masterfrom Oct 26, 2022
Jaime02:remove-mains
Merged
Conversation
This main entry points are old and worked for testing purposes. These should be removed, they are no longer needed
Contributor
Author
|
Why some matplotlib tests suddenly do not work? |
Contributor
|
Test failures appear to be related to the release of pyside6: |
Member
|
Thanks @ksunden for pointing out the mpl failure, we should probably submit a separate PR that skips those tests with the right/wrong combination of matplotlib + qt bindings. @Jaime02 can you remove the now unused imports? If you click on Files Changed, you will see the unused imports being highlighted. |
Contributor
Author
|
@j9ac9k Done! I forgot doing that 🤓 |
Contributor
Author
|
Hey @j9ac9k can you check this again please? |
Member
|
Hi @Jaime02 I was on vacation, sorry for the delayed review. This LGTM, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This main entry points are old and worked for testing purposes. These should be removed, they are no longer needed.