Prevent flickering ActionGroup when switching parameter trees#2484
Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom Oct 13, 2022
Merged
Prevent flickering ActionGroup when switching parameter trees#2484j9ac9k merged 1 commit intopyqtgraph:masterfrom
ActionGroup when switching parameter trees#2484j9ac9k merged 1 commit intopyqtgraph:masterfrom
Conversation
| self.button.clicked.connect(param.activate) | ||
|
|
||
| self.itemWidget.setLayout(layout := QtWidgets.QHBoxLayout()) | ||
| layout.setContentsMargins(0, 0, 0, 0) |
Check failure
Code scanning / CodeQL
Potentially uninitialized local variable
Member
There was a problem hiding this comment.
codeql cannot handle the walrus operator 😆
Member
|
This looks good to me @ntjess appreciate your work on fine-tuning this more! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup from 9b59e3e -- I didn't catch the issue for
ActionGroupsince it only happens when a tree is changed, i.e.:I would add a test case for this, but I'm not sure how to programmatically check for an intermediately spawned top window.