fix segmented line mode with no segments#2481
Merged
j9ac9k merged 2 commits intopyqtgraph:masterfrom Oct 11, 2022
Merged
Conversation
Member
|
Oooof @pijyoi thanks for the fix. Should a test case be added to catch this? |
Contributor
Author
There goes my 1-char PR... |
Member
|
We can split it into multiple PRs if that’s a badge you’re going after :)
…On Tue, Oct 11, 2022 at 07:45 pijyoi ***@***.***> wrote:
Should a test case be added to catch this?
There goes my 1-char PR...
—
Reply to this email directly, view it on GitHub
<#2481 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAE5Z7VRLHPNZEQCWKDVLNLWCV4QXANCNFSM6AAAAAARB5CJHI>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Member
|
Thanks for jumping on this @pijyoi Should probably release 0.13.2 before long with this fix... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug occurs under both PyQt and PySide. It was introduced in aac73a8 when adding support for the (potential) array form of
drawLines()under PySide6. In that commit,arrayToLineSegmentswas modified to return a one or two element tuple. The early return codepath in the function was not similarly modified to return a tuple.This early return codepath would be triggered by a dataset of length one. A length zero dataset would exit even earlier and thus not trigger this bug.
How to trigger the bug:
Fixes #2479