test and fix for ChecklistParameter.show bug#2480
Merged
ntjess merged 2 commits intopyqtgraph:masterfrom Oct 11, 2022
Merged
Conversation
Contributor
Author
|
Thanks @ntjess for showing me where to fix this! |
ntjess
reviewed
Oct 11, 2022
Contributor
|
Test case and fix LGTM, thanks @outofculture! @j9ac9k I assume if this is assigned to me I have the authority to push the green button 📗 |
Member
PUSH THE BUTAN!!! ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ChecklistParameters weren't able to show/hide, which was traced to a lack of super call in
optsChanged. All other parameter types were checked for similar problems, but none found. The test mocks the Qt lib'ssetHiddento be able to verify behavior.