ROI: Add test with mouseDrag event and check snapping#2476
Merged
outofculture merged 1 commit intopyqtgraph:masterfrom Oct 11, 2022
Merged
ROI: Add test with mouseDrag event and check snapping#2476outofculture merged 1 commit intopyqtgraph:masterfrom
outofculture merged 1 commit intopyqtgraph:masterfrom
Conversation
Member
|
Hi @dgoeries this LGTM, but I'll defer to @outofculture to merge. Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By working on the scaleSnap (x, y) feature, i realized that the changes will become noisy.
I do a pre step here by flaking the test region and adding a simple test with a rect roi for snapping. No logical changes are involved.