fix: use connect='finite' if finite-ness of data is unknown#2471
Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom Oct 7, 2022
Merged
fix: use connect='finite' if finite-ness of data is unknown#2471j9ac9k merged 1 commit intopyqtgraph:masterfrom
j9ac9k merged 1 commit intopyqtgraph:masterfrom
Conversation
Member
|
Thanks @pijyoi as always, love the diff. Thank you @alanbowman for reporting the issue in the mail list, and subsequently creating #2456 with an example that could be reproduced. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PlotDataItemdefaults toconnect='auto'. In the course of its processing,PlotDataItemmight perform a finite-ness check on the data for its own purpose.Given a dataset that contains non-finites,
PlotDataItemswitches to usingconnect='finite'.PlotDataItemswitches to usingconnect='all'.This ends up in a situation where such a dataset is sometimes drawn connected, sometimes drawn disconnected.
This PR changes (2) to use
connect='finite'. This causes the underlyingPlotCurveItem(viaarrayToQPath) to perform its own finite checking.Test cases can be found in #2456.
Fixes #2456