Fix Qt crash course example#2470
Merged
j9ac9k merged 2 commits intopyqtgraph:masterfrom Oct 6, 2022
Jaime02:fix-qtcrashcourse
Merged
Fix Qt crash course example#2470j9ac9k merged 2 commits intopyqtgraph:masterfrom Jaime02:fix-qtcrashcourse
j9ac9k merged 2 commits intopyqtgraph:masterfrom
Jaime02:fix-qtcrashcourse
Conversation
Updated to work with PyQt6. Fully compatible with PySide6. Can work with PyQt5 / PySide2 changing exec to exec_
pijyoi
reviewed
Oct 5, 2022
Contributor
Author
|
Seems like a test got stuck, quite weird right? |
Member
|
Thanks @Jaime02 for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated to work with PyQt6. Fully compatible with PySide6. Can work with PyQt5 / PySide2 changing exec to exec_
Detail the reasoning behind the code change. If there is an associated issue that this PR will resolve add
Fixes #2129