Remove all import *#2468
Conversation
I have removed all the import * code, this makes all imports implicit.
|
Hi @Jaime02 Thanks for the PR. The openGL related changes may need to be undone, those imports were very sensitive (hence the #noqa next to them). |
|
@j9ac9k why? Is there a specific reason for importing all OpenGL stuff? |
Hi @Jaime02 The import order is important here as some of the opengl functions/objects are intended to get clobbered/overwritten through the import sequence. I learned this the hard way when I ran With the change you have proposed, the next time isort is run, all the opengl code will not work. While other maintainers may feel differently, I'm of the opinion that any import statement with |
Go back to from `OpenGL.GL import *` imports
|
thanks @Jaime02 this LGTM, merging! |
I have removed all the import * code, this makes all imports implicit.