unify win32 and unix mmap codepaths#2457
Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom Oct 3, 2022
Merged
Conversation
| else: | ||
| self.shmFile = open(shmFileName, 'r') | ||
| opener = None | ||
| self.shmFile = open(shmFileName, 'rb', opener=opener) |
Check warning
Code scanning / CodeQL
File is not always closed
Member
|
Love this diff @pijyoi Thanks so much for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2445 added a fix for FreeBSD platforms to take the same codepath as macOS.
This PR unifies (mostly) the win32 and unix codepaths and at the same time does feature testing for mremap so that platform detection does not need to be done. (FreeBSD and macOS are not the only unix platforms to not have mremap)