interact() defaults to ON_ACTION behavior and accepts runActionTemplate argument#2432
Merged
ntjess merged 3 commits intopyqtgraph:masterfrom Sep 27, 2022
Merged
Conversation
interact() defaults to ON_ACTION behavior and accepts runActionTemplate argument
| host = interact(interactive, runOptions=RunOptions.ON_CHANGED) | ||
| interactive.disconnect() | ||
| host["a"] = 20 | ||
| assert value == 10 |
Check warning
Code scanning / CodeQL
Redundant comparison
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ported a substantial number of parameter use cases to rely on
interactand found that the majority don't favor running on change. The main motivation for that default was to avoid creating a childRunparameter, but this is no longer a concern with the introduction ofActionGroupParameter. This also aligns with the principle of least astonishment, that a (potentially expensive) function shouldn't automatically run unless a button is pressed.Along with this, the PR also allows
interact()to listen for button-specific keywords likeshortcutandiconin its argument list.