Skip to content

Fix missing import in Flowchart.py#2421

Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom
Puff-Machine:flowchart-missing-import
Sep 22, 2022
Merged

Fix missing import in Flowchart.py#2421
j9ac9k merged 1 commit intopyqtgraph:masterfrom
Puff-Machine:flowchart-missing-import

Conversation

@Puff-Machine
Copy link
Copy Markdown
Contributor

@Puff-Machine Puff-Machine commented Sep 21, 2022

A missing import in Flowchart.py causes the following errors when updating fileNameLabel on the flowchart widget:

Traceback (most recent call last):
  File "venv/lib/python3.10/site-packages/pyqtgraph/flowchart/Flowchart.py", line 686, in setCurrentFile
    self.ui.fileNameLabel.setText("<b>%s</b>" % os.path.split(self.currentFileName)[1])
NameError: name 'os' is not defined
Traceback (most recent call last):
  File "venv/lib/python3.10/site-packages/pyqtgraph/flowchart/Flowchart.py", line 657, in fileSaved
    self.setCurrentFile(fileName)
  File "venv/lib/python3.10/site-packages/pyqtgraph/flowchart/Flowchart.py", line 686, in setCurrentFile
    self.ui.fileNameLabel.setText("<b>%s</b>" % os.path.split(self.currentFileName)[1])
NameError: name 'os' is not defined
Aborted (core dumped)

@j9ac9k
Copy link
Copy Markdown
Member

j9ac9k commented Sep 22, 2022

Wow, how did this sneak by... thanks for the PR @Puff-Machine Merging.

@j9ac9k j9ac9k merged commit 6477e45 into pyqtgraph:master Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Puff-Machine @j9ac9k