Skip to content

Bump qt min version and remove code slated for removal in 0.13.0#2403

Merged
j9ac9k merged 9 commits intopyqtgraph:masterfrom
j9ac9k:bump-qt-min-version
Sep 1, 2022
Merged

Bump qt min version and remove code slated for removal in 0.13.0#2403
j9ac9k merged 9 commits intopyqtgraph:masterfrom
j9ac9k:bump-qt-min-version

Conversation

@j9ac9k
Copy link
Copy Markdown
Member

@j9ac9k j9ac9k commented Aug 28, 2022

In preparation for the 0.13.0 release, we are bumping up the minimum Qt required version to 5.15/6.2+ (from 5.12+/6.1+).

TODO

  • Change Qt version check to a warning from a raised exception
  • Undo removal of code that was needed for Qt 5.12 support (can talk about removing after the next release)
  • Consider emitting warnings on if-checks for newer Qt versions.
  • Remove lazyGetattr in Qt/__init__.py as we no longer support accessing QtWidgets via QtGui

Files that need updates

Confirm the following files have been either updated or there has been a determination that no update is needed.

  • README.md
  • setup.py N/A
  • tox.ini
  • .github/workflows/main.yml and associated requirements.txt and conda environemt.yml files
  • pyproject.toml N/A
  • binder/requirements.txt N/A

@j9ac9k j9ac9k force-pushed the bump-qt-min-version branch 2 times, most recently from a60c098 to 80177fa Compare August 28, 2022 19:08
@j9ac9k j9ac9k changed the title Bump qt min version Bump qt min version and remove code slated for removal in 0.13.0 Aug 28, 2022
@j9ac9k j9ac9k force-pushed the bump-qt-min-version branch from 68cf245 to 5ce7152 Compare August 28, 2022 23:00
@j9ac9k j9ac9k force-pushed the bump-qt-min-version branch from 5ce7152 to a5ecf81 Compare August 29, 2022 00:28
@j9ac9k j9ac9k marked this pull request as draft August 30, 2022 15:40
@j9ac9k j9ac9k force-pushed the bump-qt-min-version branch from a5ecf81 to 2797df3 Compare August 31, 2022 05:22
@j9ac9k j9ac9k marked this pull request as ready for review August 31, 2022 05:23
@j9ac9k j9ac9k force-pushed the bump-qt-min-version branch from 2797df3 to be9651a Compare August 31, 2022 05:37
@j9ac9k j9ac9k force-pushed the bump-qt-min-version branch from be9651a to fbb48a3 Compare August 31, 2022 05:42
@j9ac9k
Copy link
Copy Markdown
Member Author

j9ac9k commented Aug 31, 2022

Now need to remove those pesky unused warning module imports

@j9ac9k j9ac9k merged commit 3de5d58 into pyqtgraph:master Sep 1, 2022
@j9ac9k j9ac9k deleted the bump-qt-min-version branch September 1, 2022 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants