Skip to content

getHistogramRange for HistogramLUTItem#2397

Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom
kremeyer:patch-2
Aug 17, 2022
Merged

getHistogramRange for HistogramLUTItem#2397
j9ac9k merged 1 commit intopyqtgraph:masterfrom
kremeyer:patch-2

Conversation

@kremeyer
Copy link
Copy Markdown
Contributor

@kremeyer kremeyer commented Aug 16, 2022 •
edited
Loading

pyqtgraph.HistogramLUTItem already had the setter setHistogramRange, but was missing the getter getHistogramRange. I added it.

@kremeyer
getHistogramRange for HistogramLUTItem
d4f7490 
`HistogramLUTItem` already hat the setter, but was missing the getter...
@j9ac9k
Copy link
Copy Markdown
Member

j9ac9k commented Aug 17, 2022

Hi @kremeyer

Thanks for the PR. Normally I would say we should move away from def get<Thing> naming of methods, as they don't match up w/ the Qt framework's naming scheme, but given that the HistogramLUTItem already has numerous methods that follow that naming scheme, I think this is the one place that I'm ok with it.

Thanks for the PR, this LGTM, merging!

@j9ac9k j9ac9k merged commit 90d93d0 into pyqtgraph:master Aug 17, 2022
@kremeyer kremeyer deleted the patch-2 branch August 17, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kremeyer @j9ac9k