Invalidate cached properties on geometryChanged signal#2357
Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom Jul 12, 2022
Merged
Invalidate cached properties on geometryChanged signal#2357j9ac9k merged 1 commit intopyqtgraph:masterfrom
j9ac9k merged 1 commit intopyqtgraph:masterfrom
Conversation
Member
Author
|
@danielhrisca if you have some time and want to verify this does not penalize the performance improvement you introduced in #2198 that would be appreciated. @Seaspider1 if you are able to test to verify this PR fixes your issue, that would be greatly appreciated. |
Comment on lines
+30
to
+38
| # def itemChange(self, change, value): | ||
| # # BEWARE: Calling QGraphicsWidget.itemChange can lead to crashing! | ||
| # # ret = QtWidgets.QGraphicsWidget.itemChange(self, change, value) # segv occurs here | ||
| # # The default behavior is just to return the value argument, so we'll do that | ||
| # # without calling the original method. | ||
| # ret = value | ||
| # if change in [self.ItemParentHasChanged, self.ItemSceneHasChanged]: | ||
| # self._updateView() | ||
| # return ret |
Check notice
Code scanning / CodeQL
Commented-out code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2345
Since #2198 GraphicsWidget attempts to cache properties such as boundingRect; unfortunately it does not appear those caches were being appropriately reset. Luckily the fix was straightforward as
QGraphicsWidgethas ageometryChangedsignal that I used to trigger a cache invalidation.Took the opportunity to clean up some formatting issues with the file so pycharm can stop having a cow.